Miguel Arroyo

mayanez commented on pull request vikunja/vikunja#1634

2023-11-10 03:52:11 +00:00

feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

Fair enough. I made the change back to a *Task as requested.

mayanez pushed to feat/caldav-relatedto at mayanez/api

2023-11-10 03:50:48 +00:00

bd36afbd1e refactor: PR Feedback

mayanez commented on pull request vikunja/vikunja#1634

2023-11-08 03:21:28 +00:00

feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

Rebased to the latest main. There seems to be some errors on some unrelated todoist files, otherwise everything seems to be in order.

That's fixed now!

Great! I rebased again so…

mayanez pushed to feat/caldav-relatedto at mayanez/api

2023-11-08 03:21:00 +00:00

d38f83bd9d refactor: PR Feedback

af7ab76771 fix: Get() in GetTaskSimpleByUUID() requires object

9c1796d154 fix(test): Update test due to change in tasks

d6f6834654 test(caldav): Adds RELATED-TO integration tests

4354299dd3 test(caldav): Add RELATED-TO parsing/formatting tests

Compare 16 commits »

mayanez commented on pull request vikunja/vikunja#1634

2023-11-08 03:20:42 +00:00

feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

The API for the Get needs memory allocated which it will then fill.

The reason for the error (and this change) was that the *Task was null thus causing a segfault. We could potentially…

mayanez commented on pull request vikunja/vikunja#1634

2023-11-07 03:56:57 +00:00

feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

Rebased to the latest main. There seems to be some errors on some unrelated todoist files, otherwise everything seems to be in order.

mayanez pushed to feat/caldav-relatedto at mayanez/api

2023-11-07 03:23:46 +00:00

93ba7d5267 refactor: PR Feedback

6b2b748666 fix: Get() in GetTaskSimpleByUUID() requires object

430e7d1175 fix(test): Update test due to change in tasks

3ec6664a70 test(caldav): Adds RELATED-TO integration tests

dcae80c0c4 test(caldav): Add RELATED-TO parsing/formatting tests

Compare 8 commits »

mayanez pushed to feat/caldav-relatedto at mayanez/api

2023-11-07 03:13:01 +00:00

6607169332 refactor: PR Feedback

5caeb5cb0c fix: Get() in GetTaskSimpleByUUID() requires object

ea978f52b0 fix(test): Update test due to change in tasks

7f27a3d165 test(caldav): Adds RELATED-TO integration tests

e239616e4d test(caldav): Add RELATED-TO parsing/formatting tests

Compare 8 commits »

mayanez commented on pull request vikunja/vikunja#1634

2023-11-06 01:46:42 +00:00

feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

Might be worth putting Co-authored-by: Erwan Martin <public@fzwte.net> in the commit messages so that Erwan gets some credit for this contribution?

Of course! I hadn't personally used this…

mayanez pushed to feat/caldav-relatedto at mayanez/api

2023-11-06 01:45:26 +00:00

90052ca5e5 refactor: PR Feedback

cc299b0a92 fix: Get() in GetTaskSimpleByUUID() requires object

10e8800435 fix(test): Update test due to change in tasks

a4a78ef31b test(caldav): Adds RELATED-TO integration tests

72f48855c1 test(caldav): Add RELATED-TO parsing/formatting tests

Compare 6 commits »

mayanez commented on pull request vikunja/vikunja#1634

2023-11-02 05:27:26 +00:00

feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

Makes sense @zewaren 👍

I should clarify what I meant when I said that the dummy task will end up in the list. It will only remain as the "DUMMY" task if for some reason the client fails…

mayanez commented on pull request vikunja/vikunja#1634

2023-11-02 05:22:30 +00:00

feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

I was running into a bug with GetTaskSimplyByUUID in that the xorm Get() requires an object, but the function signature had a *Task.

I addressed it so please double check it as I'm not…

mayanez pushed to feat/caldav-relatedto at mayanez/api

2023-11-02 05:17:00 +00:00

c6a3380e69 refactor: PR Feedback

dec71cef35 fix: Get() in GetTaskSimpleByUUID() requires object

Compare 2 commits »

mayanez pushed to feat/caldav-relatedto at mayanez/api

2023-11-02 02:57:54 +00:00

3dfad50791 refactor: PR Feedback

mayanez commented on pull request vikunja/vikunja#1634

2023-11-01 04:32:18 +00:00

feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

We move one of the tasks from bucket 1 to 38 in pkg/db/fixtures/tasks.yml:377.

mayanez commented on pull request vikunja/vikunja#1634

2023-11-01 04:29:16 +00:00

feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

Fixed.

mayanez pushed to feat/caldav-relatedto at mayanez/api

2023-11-01 04:28:26 +00:00

f55b2c2fe1 refactor: PR Feedback

mayanez commented on pull request vikunja/vikunja#1634

2023-11-01 03:20:21 +00:00

feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

Worst case, we'll end up with the dummy task in the list.

I haven't encountered it yet as I suppose this would mean the client is broken to begin with. It would need to be requesting tasks to…

mayanez pushed to feat/caldav-relatedto at mayanez/api

2023-10-30 18:55:13 +00:00

3498bdd9b4 fix(test): Update test due to change in tasks

7a39b337c9 test(caldav): Adds RELATED-TO integration tests

a300955dc8 test(caldav): Add RELATED-TO parsing/formatting tests

b98ef14986 feat(caldav): Adds RELATED-TO property support

Compare 4 commits »

mayanez commented on pull request vikunja/vikunja#1442

2023-10-30 18:16:18 +00:00

WIP: feat(caldav): Add support for subtasks in CalDAV.

Hey @zewaren,

I opened the PR here vikunja/api#1634