konrad
/
Library
1
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity

Modified http status code on error

This commit is contained in:
konrad 2018-01-24 13:15:28 +01:00 committed by kolaente
parent dec5db7649
commit c8da860eab
Signed by: konrad
GPG Key ID: F40E70337AB24C9B
7 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
routes/api/v1/author_delete.go
View File

@ -35,7 +35,7 @@ func AuthorDelete(c echo.Context) error {
if err != nil { if err != nil {
if models.IsErrIDCannotBeZero(err) { if models.IsErrIDCannotBeZero(err) {
return c.JSON(http.StatusInternalServerError, models.Message{"Id cannot be 0"}) return c.JSON(http.StatusBadRequest, models.Message{"Id cannot be 0"})
} }
return c.JSON(http.StatusInternalServerError, models.Message{"Could not delete author."}) return c.JSON(http.StatusInternalServerError, models.Message{"Could not delete author."})
} }

2
routes/api/v1/authors_add_update.go
View File

@ -63,7 +63,7 @@ func AuthorAddOrUpdate(c echo.Context) error {
if err != nil { if err != nil {
if models.IsErrAuthorCannotBeEmpty(err) { if models.IsErrAuthorCannotBeEmpty(err) {
return c.JSON(http.StatusInternalServerError, models.Message{"Id cannot be 0"}) return c.JSON(http.StatusBadRequest, models.Message{"Id cannot be 0"})
} }
return c.JSON(http.StatusInternalServerError, models.Message{"Error"}) return c.JSON(http.StatusInternalServerError, models.Message{"Error"})
} }

2
routes/api/v1/book_delete.go
View File

@ -35,7 +35,7 @@ func BookDelete(c echo.Context) error {
if err != nil { if err != nil {
if models.IsErrIDCannotBeZero(err) { if models.IsErrIDCannotBeZero(err) {
return c.JSON(http.StatusInternalServerError, models.Message{"Id cannot be 0"}) return c.JSON(http.StatusBadRequest, models.Message{"Id cannot be 0"})
} }
return c.JSON(http.StatusInternalServerError, models.Message{"Could not delete book."}) return c.JSON(http.StatusInternalServerError, models.Message{"Could not delete book."})
} }

4
routes/api/v1/books_add_update.go
View File

@ -7,7 +7,6 @@ import (
"net/http" "net/http"
"strconv" "strconv"
"strings" "strings"
"fmt"
) )
// BookAddOrUpdate is the handler to add a book // BookAddOrUpdate is the handler to add a book
@ -63,9 +62,8 @@ func BookAddOrUpdate(c echo.Context) error {
newBook, err := models.AddOrUpdateBook(*datBook) newBook, err := models.AddOrUpdateBook(*datBook)
if err != nil { if err != nil {
fmt.Println(err)
if models.IsErrAuthorCannotBeEmpty(err) { if models.IsErrAuthorCannotBeEmpty(err) {
return c.JSON(http.StatusInternalServerError, models.Message{"Id cannot be 0."}) return c.JSON(http.StatusBadRequest, models.Message{"Id cannot be 0."})
} }
if models.IsErrBookTitleCannotBeEmpty(err) { if models.IsErrBookTitleCannotBeEmpty(err) {

2
routes/api/v1/items_delete.go
View File

@ -35,7 +35,7 @@ func ItemDelete(c echo.Context) error {
if err != nil { if err != nil {
if models.IsErrIDCannotBeZero(err) { if models.IsErrIDCannotBeZero(err) {
return c.JSON(http.StatusInternalServerError, models.Message{"Id cannot be 0"}) return c.JSON(http.StatusBadRequest, models.Message{"Id cannot be 0"})
} }
return c.JSON(http.StatusInternalServerError, models.Message{"Could not delete item."}) return c.JSON(http.StatusInternalServerError, models.Message{"Could not delete item."})
} }

2
routes/api/v1/publishers_delete.go
View File

@ -35,7 +35,7 @@ func PublisherDelete(c echo.Context) error {
if err != nil { if err != nil {
if models.IsErrIDCannotBeZero(err) { if models.IsErrIDCannotBeZero(err) {
return c.JSON(http.StatusInternalServerError, models.Message{"Id cannot be 0"}) return c.JSON(http.StatusBadRequest, models.Message{"Id cannot be 0"})
} }
return c.JSON(http.StatusInternalServerError, models.Message{"Could not delete publisher."}) return c.JSON(http.StatusInternalServerError, models.Message{"Could not delete publisher."})
} }

2
routes/api/v1/user_delete.go
View File

@ -40,7 +40,7 @@ func UserDelete(c echo.Context) error {
if err != nil { if err != nil {
if models.IsErrIDCannotBeZero(err) { if models.IsErrIDCannotBeZero(err) {
return c.JSON(http.StatusInternalServerError, models.Message{"Id cannot be 0"}) return c.JSON(http.StatusBadRequest, models.Message{"Id cannot be 0"})
} }
return c.JSON(http.StatusInternalServerError, models.Message{"Could not delete user."}) return c.JSON(http.StatusInternalServerError, models.Message{"Could not delete user."})
} }