fix(task): delete the task after all related attributes to prevent task not found errors

This commit is contained in:
kolaente 2024-01-28 12:23:25 +01:00
parent 1630e4fc08
commit a20f6ac815
Signed by: konrad
GPG Key ID: F40E70337AB24C9B

View File

@ -1432,10 +1432,6 @@ func (t *Task) Delete(s *xorm.Session, a web.Auth) (err error) {
return err
}
if _, err = s.ID(t.ID).Delete(Task{}); err != nil {
return err
}
// Delete assignees
if _, err = s.Where("task_id = ?", t.ID).Delete(TaskAssginee{}); err != nil {
return err
@ -1484,6 +1480,12 @@ func (t *Task) Delete(s *xorm.Session, a web.Auth) (err error) {
return
}
// Actually delete the task
_, err = s.ID(t.ID).Delete(Task{})
if err != nil {
return err
}
doer, _ := user.GetFromAuth(a)
err = events.Dispatch(&TaskDeletedEvent{
Task: fullTask,