From 2d5c49639784f58948f8ea5a21544174cdf6a5ef Mon Sep 17 00:00:00 2001 From: kolaente Date: Tue, 27 Feb 2024 16:10:19 +0100 Subject: [PATCH] fix(kanban): pass active filters down to task lazy loading Before this change, applying a filter and then scrolling a bucket would not use that filter when lazy loading the tasks in that bucket. That resulted in all tasks being loaded, regardless if the filter applied to them. --- frontend/src/stores/kanban.ts | 5 +++-- frontend/src/views/project/ProjectKanban.vue | 10 +++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/frontend/src/stores/kanban.ts b/frontend/src/stores/kanban.ts index b07f80512e..94c6267485 100644 --- a/frontend/src/stores/kanban.ts +++ b/frontend/src/stores/kanban.ts @@ -246,8 +246,9 @@ export const useKanbanStore = defineStore('kanban', () => { } async function loadNextTasksForBucket( - {projectId, ps = {}, bucketId} : - {projectId: IProject['id'], ps, bucketId: IBucket['id']}, + projectId: IProject['id'], + ps, + bucketId: IBucket['id'], ) { const isLoading = bucketLoading.value[bucketId] ?? false if (isLoading) { diff --git a/frontend/src/views/project/ProjectKanban.vue b/frontend/src/views/project/ProjectKanban.vue index 48ea823596..d5acd20769 100644 --- a/frontend/src/views/project/ProjectKanban.vue +++ b/frontend/src/views/project/ProjectKanban.vue @@ -416,11 +416,11 @@ function handleTaskContainerScroll(id: IBucket['id'], projectId: IProject['id'], return } - kanbanStore.loadNextTasksForBucket({ - projectId: projectId, - params: params.value, - bucketId: id, - }) + kanbanStore.loadNextTasksForBucket( + projectId, + params.value, + id, + ) } function updateTasks(bucketId: IBucket['id'], tasks: IBucket['tasks']) {